fix react-frame-component by supporting nullish portals #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -31 B (0%) Total Size: 57 kB
ℹ️ View Unchanged
|
developit
reviewed
Feb 17, 2023
compat/src/portals.js
Outdated
| // When we come from a conditional render, on a mounted | ||
| // portal we should clear the DOM. | ||
| else if (_this._temp) { | ||
| if (!props._vnode && _this._temp) { |
There was a problem hiding this comment.
I think we can just remove this condition and the this.unmount call now. When a null vnode is received, we will render the provider with null as it's only child, which produces the same result as calling unmount (because there is no componentDidUnmount method on this provider).
|
LGTM but I'd like to check if we can remove that condition entirely. |
rschristian
reviewed
Mar 14, 2023
|
Closing due to inactivity |
marvinhagemeister
approved these changes
Jul 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2653
This allows for nullish portals